Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the differences between upstream and downstream builds #5453

Closed
wants to merge 3 commits into from

Conversation

rcritten
Copy link
Contributor

Make it easier to share the same spec file between upstream and downstream (at least CentOS and RHEL) builds.

This includes:

  • Replace some FreeIPA references with IPA to be more name-agnostic.
  • Drop csrgen which was never feature complete, doesn't work today.
  • Tweak the UI builder which was already capable of picking a tool to be more generic in its output.

The spec file itself has already been tweaked to handle picking the right dependencies per distribution.

@rcritten rcritten added the ipa-next Mark as master (4.13) only label Jan 19, 2021
In order to simplify the build process between upstream FreeIPA
and downstream builds (such as CentOS Stream) we are changing
some file references from FreeIPA to IPA (and Identity Management).

https://pagure.io/freeipa/issue/8669

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
This was never feature complete and currently has issues and
we lack the resources to maintain it.

Drop it for now. It can be revived from git history in the
future if we see the need.

https://pagure.io/freeipa/issue/8669

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
It specifically referenced using Python rjsmin while the
actual script would pick the minimizer based on the underlying
distribution.

https://pagure.io/freeipa/issue/8669

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@rcritten
Copy link
Contributor Author

Downstream builders probably will want to replace the logos and/or update the CSS to match whatever color scheme they want the UI:

install/ui/css/patternfly.css
install/ui/less/brand.less
install/ui/less/patternfly.less

@tiran tiran added the re-run Trigger a new run of PR-CI label Jan 20, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jan 20, 2021
@abbra abbra added the ack Pull Request approved, can be merged label Jan 20, 2021
@abbra
Copy link
Contributor

abbra commented Jan 20, 2021

LGTM

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Jan 21, 2021
@flo-renaud
Copy link
Contributor

master:

  • 6518a60 Change FreeIPA references to IPA and Identity Management
  • 767232b Remove support for csrgen
  • 8021a20 Remove references to rjsmin in UI compile.sh

@flo-renaud flo-renaud closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-next Mark as master (4.13) only pushed Pull Request has already been pushed
Projects
None yet
5 participants