[Backport][ipa-4-9] ipatests: use pexpect for controlling interactive command line utilities #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pexpect module can be used for controlling and testing interactive command-line programs. The wrapper adds testing-oriented features like logging and automatic process termination and default check for process exit status.
`ktutil` is a REPL-style utility that can be controlled only interactively. The common approach of sending commands to stdin does not work with it on systems where `readline` library has version less then 8.0 due to a bug in that version. With `pexpect` we avoid this bug because it emulates the terminal when interacting with spawned process instead of simply sending all input to stdin.
…nstall During interactive session of `ipa-adtrust-install` the user needs to answer several questions. This was done by sending all answers to the processes stdin without analyzing the questions. If the installation scenario changes at some point we can get on of the following results: * the test fails in the end and the root cause is not obvious * if a new question was added * test does not fail but answers are provided for wrong questions - in this case scope of test case changes without being noticed If we use `pexpect` for controlling the session, the test will fail immediately when it encounters unexpected question.
|
Closing the PR since commit messages need to be updated with a link to pagure ticket. New PR will be created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #5460 was pushed to master and backport to ipa-4-9 is required.