Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: update expected error message #5547

Closed
wants to merge 1 commit into from
Closed

ipatests: update expected error message #5547

wants to merge 1 commit into from

Conversation

flo-renaud
Copy link
Contributor

With commit ec6698f , the error message has changed from
Unable to communicate with CMS (503)
to
Request failed with status 503: Non-2xx response from CA REST API: 503. (503)

Related: https://pagure.io/freeipa/issue/8704

@flo-renaud
ipatests: update expected error message
bbc5e19 
With commit ec6698f , the error message has changed from
  Unable to communicate with CMS (503)
to
  Request failed with status 503: Non-2xx response from CA REST API: 503.  (503)

Related: https://pagure.io/freeipa/issue/8704
@flo-renaud flo-renaud added the ipa-4-9 Mark for backport to ipa 4.9 label Feb 13, 2021
@flo-renaud flo-renaud mentioned this pull request Feb 13, 2021
Closed
@flo-renaud flo-renaud added the re-run Trigger a new run of PR-CI label Feb 13, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Feb 13, 2021
@flo-renaud flo-renaud added the re-run Trigger a new run of PR-CI label Feb 13, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Feb 13, 2021
@abbra abbra added the re-run Trigger a new run of PR-CI label Feb 14, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Feb 14, 2021
@flo-renaud flo-renaud added the re-run Trigger a new run of PR-CI label Feb 14, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Feb 14, 2021
@flo-renaud
Copy link
Contributor Author

The temp commit failure is linked to known issue, #8506 Nightly failure in ipa-server-install --uninstall: org.freedesktop.DBus.Error.NoReply

@abbra
Copy link
Contributor

abbra commented Feb 15, 2021

Should we first merge #5505 and then re-run this one?

@flo-renaud
Copy link
Contributor Author

Should we first merge #5505 and then re-run this one?

IMO no need to wait. The test failure was happening in test_ipahealthcheck.py::TestIpaHealthCheck::test_ipahealthcheck_dogtag_ca_connectivity_check (see the nightly PR #710) but this specific test method was green in the temp commit.

@abbra
Copy link
Contributor

abbra commented Feb 15, 2021

OK. LGTM then, please remove the temp commit.

amore17
amore17 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@amore17 amore17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amore17 amore17 added the ack Pull Request approved, can be merged label Feb 15, 2021
@abbra abbra added the re-run Trigger a new run of PR-CI label Feb 15, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Feb 15, 2021
@abbra abbra added the pushed Pull Request has already been pushed label Feb 15, 2021
@abbra
Copy link
Contributor

abbra commented Feb 15, 2021

master:

  • 137b39c ipatests: update expected error message

@abbra abbra closed this Feb 15, 2021
@abbra abbra mentioned this pull request Feb 15, 2021
Closed
@flo-renaud flo-renaud deleted the t8704 branch February 15, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amore17 amore17 amore17 approved these changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@flo-renaud @abbra @amore17 @freeipa-pr-ci