ipatests: introduce wait_for_replication in test_rolecheck_Trust #5635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Hi @mrizwan93
thanks for the PR. I have a nitpick: I would enhance the comment to explain why we need to wait for replication:
# wait for replication to propagate the change on cn=adtrust agents,cn=sysaccounts,cn=etc,dc=ipa,dc=test as the ipa server-role-find call is using this entry to build its output
mrizwan93
force-pushed
the
fix-backup-rolecheck
branch
2 times, most recently
from
3c672d6
to
904a786
Compare
|
@mrizwan93 thanks for the fix, LGTM. You can remove the temp commit. |
Test was randomly failing if the query for the server role is executed before the replication had time to replicate the changes on cn=adtrust agents,cn=sysaccounts,cn=etc,dc=ipa,dc=test, as the server role is read using this entry. related: https://pagure.io/freeipa/issue/8553 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
mrizwan93
force-pushed
the
fix-backup-rolecheck
branch
from
904a786
to
aae7a0b
Compare
mrizwan93
added
ipa-4-9
|
Adding ACK per #5635 (comment) |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was randomly failing if the query for the server role is
executed before the replication had time to replicate the
changes on cn=adtrust agents,cn=sysaccounts,cn=etc,dc=ipa,dc=test,
as the server role is read using this entry.
related: https://pagure.io/freeipa/issue/8553
Signed-off-by: Mohammad Rizwan myusuf@redhat.com