ipatests: Test ipa-cert-fix warns when startup directive is missing from CS.cfg #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrizwan93
force-pushed
the
fix-startup-directive
branch
2 times, most recently
from
32aeb57
to
db22edc
Compare
|
Hi @mrizwan93 The test needs to have different expectations depending on the version of pki-server that is installed. |
mrizwan93
force-pushed
the
fix-startup-directive
branch
from
db22edc
to
8088773
Compare
flo-renaud
reviewed
Jun 29, 2021
|
|
||
| if (tasks.get_pki_version(self.master) | ||
| < tasks.parse_version('10.11.0')): | ||
| assert err_msg1 and err_msg2 in result.stderr_text |
There was a problem hiding this comment.
The above assert is equivalent to assert (err_msg1 is not None) and (err_msg2 in stderr), which is not what the test should check.
mrizwan93
force-pushed
the
fix-startup-directive
branch
2 times, most recently
from
6c96d94
to
88f6550
Compare
|
Hi @mrizwan93 |
…rom CS.cfg Earlier it used to fail when startup directive missing from CS.cfg. With dogtagpki/pki#3466, it changed to display a warning than failing. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
mrizwan93
force-pushed
the
fix-startup-directive
branch
from
88f6550
to
b79f375
Compare
|
master:
|
|
Hi @mrizwan93 |
mrizwan93
added a commit
to mrizwan93/freeipa
that referenced
this pull request
Aug 2, 2021
In freeipa#5855 was looking into stdout_text for warning instead of stderr_text, hence was failing for pki version > 10.11.0. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
mrizwan93
added a commit
to mrizwan93/freeipa
that referenced
this pull request
Aug 3, 2021
In freeipa#5855 was looking into stdout_text for warning instead of stderr_text, hence was failing for pki version > 10.11.0. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
mrizwan93
added a commit
to mrizwan93/freeipa
that referenced
this pull request
Aug 3, 2021
In freeipa#5855 was looking into stdout_text for warning instead of stderr_text, hence was failing for pki version > 10.11.0. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
abbra
pushed a commit
that referenced
this pull request
Aug 4, 2021
In #5855 was looking into stdout_text for warning instead of stderr_text, hence was failing for pki version > 10.11.0. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com> Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
flo-renaud
pushed a commit
to flo-renaud/freeipa
that referenced
this pull request
Aug 4, 2021
In freeipa#5855 was looking into stdout_text for warning instead of stderr_text, hence was failing for pki version > 10.11.0. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
abbra
pushed a commit
that referenced
this pull request
Aug 4, 2021
In #5855 was looking into stdout_text for warning instead of stderr_text, hence was failing for pki version > 10.11.0. related: https://pagure.io/freeipa/issue/8890 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com> Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier it used to fail when startup directive missing from CS.cfg.
With dogtagpki/pki#3466, it changed to display
a warning than failing.
related: https://pagure.io/freeipa/issue/8890
Signed-off-by: Mohammad Rizwan myusuf@redhat.com