Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: refactor test_ipa_cert_fix with tasks #5914

Closed
wants to merge 1 commit into from
Closed

ipatests: refactor test_ipa_cert_fix with tasks #5914

wants to merge 1 commit into from

Conversation

fcami
Copy link
Contributor

@fcami fcami commented Jul 21, 2021

Fixes: https://pagure.io/freeipa/issue/8932
Signed-off-by: François Cami fcami@redhat.com

@fcami fcami added WIP Work in progress - not ready yet for review ipa-4-9 Mark for backport to ipa 4.9 labels Jul 21, 2021
@fcami fcami requested a review from miskopo July 21, 2021 14:57
@fcami
Copy link
Contributor Author

fcami commented Jul 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rcritten
Copy link
Contributor

LGTM, ack when tests are green.

@fcami
Copy link
Contributor Author

fcami commented Jul 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rcritten
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@miskopo
Copy link
Member

miskopo commented Jul 22, 2021

LGTM, let's just wait for greener runs.

@fcami
Copy link
Contributor Author

fcami commented Jul 22, 2021 •
edited

@miskopo @rcritten we have a green /gating/ run.

@fcami fcami added needs review Pull Request is waiting for a review and removed WIP Work in progress - not ready yet for review labels Jul 22, 2021
@miskopo miskopo added ack Pull Request approved, can be merged needs review Pull Request is waiting for a review and removed needs review Pull Request is waiting for a review ack Pull Request approved, can be merged labels Jul 22, 2021
@miskopo
Copy link
Member

miskopo commented Jul 22, 2021

Sorry, on mobile, didn't see there is still temp commit. Removing ack not to accidentally merge it

@fcami fcami added the re-run Trigger a new run of PR-CI label Jul 23, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 23, 2021
@fcami
ipatests: refactor test_ipa_cert_fix with tasks
8f257a4 
Fixes: https://pagure.io/freeipa/issue/8932
Signed-off-by: François Cami <fcami@redhat.com>
@netoarmando
Copy link
Member

@fcami test is timing out, ['getcert', 'list'] is being executed in loop.

@fcami
Copy link
Contributor Author

fcami commented Jul 23, 2021

@netoarmando thanks for looking, I think this is due to https://pagure.io/freeipa/issue/8815 ...

@fcami fcami added the re-run Trigger a new run of PR-CI label Jul 26, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 26, 2021
mrizwan93
mrizwan93 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@mrizwan93 mrizwan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll drop my changes in 0a8e77b

@mrizwan93 mrizwan93 added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Jul 27, 2021
@fcami
Copy link
Contributor Author

fcami commented Jul 27, 2021

Thanks @mrizwan93 !

@fcami fcami added the pushed Pull Request has already been pushed label Jul 27, 2021
@fcami
Copy link
Contributor Author

fcami commented Jul 27, 2021

master:

  • 8a4a338 ipatests: refactor test_ipa_cert_fix with tasks

@fcami fcami closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizwan93 mrizwan93 mrizwan93 approved these changes

@miskopo miskopo Awaiting requested review from miskopo

Assignees

@miskopo miskopo

Labels
ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
6 participants
@fcami @rcritten @miskopo @netoarmando @mrizwan93 @freeipa-pr-ci