Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-9] Fix ldapupdate.get_sub_dict() for missing named user #5937

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 2, 2021

Manual backport of PR #5927

The named user may not be present when ipa-server-dns and bind are not
installed. NAMED_UID and NAMED_GID constants are only used with local
DNS support.

Fixes: https://pagure.io/freeipa/issue/8936
Signed-off-by: Christian Heimes cheimes@redhat.com
Co-authored-by: François Cami fcami@redhat.com
Reviewed-By: Francois Cami fcami@redhat.com
Reviewed-By: Rob Crittenden rcritten@redhat.com

The named user may not be present when ipa-server-dns and bind are not
installed. NAMED_UID and NAMED_GID constants are only used with local
DNS support.

Fixes: https://pagure.io/freeipa/issue/8936
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Co-authored-by: François Cami <fcami@redhat.com>
Reviewed-By: Francois Cami <fcami@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
@tiran tiran added the needs review Pull Request is waiting for a review label Aug 2, 2021
@tiran tiran requested review from fcami and rcritten August 2, 2021 06:32
@flo-renaud flo-renaud changed the title Fix ldapupdate.get_sub_dict() for missing named user [Backoprt][ipa-4-9] Fix ldapupdate.get_sub_dict() for missing named user Aug 2, 2021
@flo-renaud flo-renaud changed the title [Backoprt][ipa-4-9] Fix ldapupdate.get_sub_dict() for missing named user [Backport][ipa-4-9] Fix ldapupdate.get_sub_dict() for missing named user Aug 2, 2021
@tiran tiran added the re-run Trigger a new run of PR-CI label Aug 2, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Aug 2, 2021
@rcritten rcritten added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Aug 2, 2021
@rcritten
Copy link
Contributor

rcritten commented Aug 2, 2021

LGTM

@rcritten rcritten added the pushed Pull Request has already been pushed label Aug 2, 2021
@rcritten
Copy link
Contributor

rcritten commented Aug 2, 2021

ipa-4-9:

  • a1eb13c Fix ldapupdate.get_sub_dict() for missing named user

@rcritten rcritten closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants