[Backport][ipa-4-9] dnszone-add: deprecate option for setting SOA serial #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since IPA 3 [1] SOA serial is managed automatically via autoincrement, and the option of disabling this behavior was deprecated in IPA 3.3.3 [2]. As a result, the option '--serial' during DNS zone addition would be ignored as it is set during the creation. This commit adds a deprecation warning if this option is used. [1]: https://www.freeipa.org/page/V3/DNS_SOA_serial_auto-incrementation [2]: https://www.freeipa.org/page/Releases/3.3.3 Fixes: https://pagure.io/freeipa/issue/8227 Signed-off-by: Antonio Torres <antorres@redhat.com>
Tests must be updated to expect the new deprecation warning. Related: https://pagure.io/freeipa/issue/8227 Signed-off-by: Antonio Torres <antorres@redhat.com>
|
PR was ACKed automatically because this is backport of PR #5841. Wait for CI to finish before pushing. In case of questions or problems contact @antoniotorresm who is author of the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #5841 was pushed to master and backport to ipa-4-9 is required.