Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse cert chain as JSON not XML #5958

Closed
wants to merge 1 commit into from
Closed

Parse cert chain as JSON not XML #5958

wants to merge 1 commit into from

Conversation

ckelleyRH
Copy link
Contributor

On dogtagpki/pki master XML is being replaced by JSON in PKI 11.0+

The PR for dogtagpki/pki that makes this change necessary is:
dogtagpki/pki#3677

@ckelleyRH
Copy link
Contributor Author

@rcritten while I was making this change I noticed that there are CA get_status()/_parse_ca_status() methods in this script, which are still expecting XML responses. From what I can tell, they're only called by methods from the SuseCAService and RedHatCAService classes. The CI didn't pick this up, so I guess this is a gap in the coverage. Would you like me to fix this while I'm in here, otherwise someone is going to step on this landmine in the future?

@ckelleyRH
Copy link
Contributor Author

@rcritten FYI the copr repo from #5932 contains an updated build with the dogtag patch in dogtagpki/pki#3677.

@rcritten
Copy link
Contributor

rcritten commented Aug 6, 2021

Yes, I think it's worth fixing this as well.

@rcritten rcritten mentioned this pull request Aug 6, 2021
Closed
@ckelleyRH
Parse cert chain as JSON not XML
c66fdc5 
On dogtagpki/pki master XML is being replaced by JSON in PKI 11.0+

The PR for dogtagpki/pki that makes this change necessary is:
dogtagpki/pki#3677
@rcritten
Copy link
Contributor

rcritten commented Aug 6, 2021

CI tests pass in the other PR and code LGTM.

@rcritten rcritten added ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 labels Aug 6, 2021
@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Aug 9, 2021
@flo-renaud
Copy link
Contributor

master:

  • 6e2ca19 Parse cert chain as JSON not XML

@flo-renaud flo-renaud closed this Aug 9, 2021
@flo-renaud flo-renaud mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@ckelleyRH @rcritten @flo-renaud