Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-9] seccomp profile: Default to ENOSYS instead of EPERM #6052

Closed

Conversation

flo-renaud
Copy link
Contributor

This PR was opened automatically because PR #6048 was pushed to master and backport to ipa-4-9 is required.

This allows application to detect whether the kernel supports
syscall or not. Previously, an error was unconditionally EPERM.
There are many issues about glibc failed with new syscalls in containerized
environments if their host run on old kernel.

More about motivation for ENOSYS over EPERM:
opencontainers/runc#2151
opencontainers/runc#2750

See about defaultErrnoRet introduction:
opencontainers/runtime-spec#1087

Previously, FreeIPA profile was vendored from
https://github.com/containers/podman/blob/main/vendor/github.com/containers/common/pkg/seccomp/seccomp.json

Now it is merged directly from
https://github.com/containers/common/blob/main/pkg/seccomp/seccomp.json

Fixes: https://pagure.io/freeipa/issue/9008
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Oct 18, 2021
@flo-renaud
Copy link
Contributor Author

PR was ACKed automatically because this is backport of PR #6048. Wait for CI to finish before pushing. In case of questions or problems contact @stanislavlevin who is author of the original PR.

@rcritten rcritten added the pushed Pull Request has already been pushed label Oct 19, 2021
@rcritten
Copy link
Contributor

ipa-4-9:

  • 488fb10 seccomp profile: Default to ENOSYS instead of EPERM

@rcritten rcritten closed this Oct 19, 2021
@flo-renaud flo-renaud deleted the backport_pr6048_ipa-4-9 branch October 22, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants