ipatests: mark test_installation_TestInstallWithCA_DNS3 as xfail #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
added
needs review
fcami
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Hi,
Shouldn't this be conditional on the OS version like this:
osinfo.id == 'fedora' and osinfo.version_number >= (33,)
otherwise this will start failing downstream for no good reason?
Thanks @flo-renaud
The test failure is a known issue, happening on f33+. Mark as xfail until 8700 is fixed. Related: https://pagure.io/freeipa/issue/8700 Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>
|
@fcami thanks for your comment, I added the condition as suggested. |
fcami
added
ack
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failure is a known issue, happening on f33+. Mark as xfail
until 8700 is fixed.
Related: https://pagure.io/freeipa/issue/8700
Signed-off-by: Florence Blanc-Renaud flo@redhat.com