Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipatests: test_subids: test subid-match shows UID of the owner #6106

Closed
wants to merge 1 commit into from

Conversation

miskopo
Copy link
Member

@miskopo miskopo commented Nov 24, 2021

ipa subid-match should show UID of the owner instead of DN.

Related: https://pagure.io/freeipa/issue/8977

Signed-off-by: Michal Polovka mpolovka@redhat.com

info = self.assert_subid(uid, match=True)
subuid = info["ipasubuidnumber"]
result = self.master.run_command(["ipa", "subid-match",
f"--subuid={subuid}", "--raw"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @miskopo Thanks for the patch.
Could you try this without adding --raw

@stale
Copy link

stale bot commented Feb 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PR [Bot] label Feb 18, 2022
@stale
Copy link

stale bot commented Mar 9, 2022

This issue has been automatically closed as stale it has not had recent activity.

@stale stale bot closed this Mar 9, 2022
@miskopo miskopo reopened this Jun 1, 2022
@miskopo miskopo added tests Pull Request related to ipatests and removed stale Stale PR [Bot] labels Jun 1, 2022
@miskopo miskopo self-assigned this Jun 1, 2022
ipa subid-match should show UID of the owner instead of DN.

Related: https://pagure.io/freeipa/issue/8977

Signed-off-by: Michal Polovka <mpolovka@redhat.com>
@amore17
Copy link
Contributor

amore17 commented Jun 1, 2022

@miskopo Thanks for the patch.
Do we need back-port ?
You can remove temp_commit I'll ack once all tests green.

@miskopo miskopo added ipa-4-9 Mark for backport to ipa 4.9 needs review Pull Request is waiting for a review and removed WIP Work in progress - not ready yet for review labels Jun 1, 2022
@amore17 amore17 removed the needs review Pull Request is waiting for a review label Jun 1, 2022
@miskopo
Copy link
Member Author

miskopo commented Jun 1, 2022

Backport to ipa-4-9 added. Link to temp commit

@amore17 amore17 added the ack Pull Request approved, can be merged label Jun 1, 2022
@miskopo miskopo added the pushed Pull Request has already been pushed label Jun 1, 2022
@miskopo
Copy link
Member Author

miskopo commented Jun 1, 2022

master:

  • c18caaa ipatests: test_subids: test subid-match shows UID of the owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 pushed Pull Request has already been pushed tests Pull Request related to ipatests
Projects
None yet
2 participants