ipatests: fix wrong condition in xfail_context for auto private grp #6239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests TestNonPosixAutoPrivateGroup::test_idoverride_with_auto_private_group and TestPosixAutoPrivateGroup::test_gidnumber_not_corresponding_existing_group are expected to fail until SSSD fixes issues 5988 and 5989. They currently define an xfail_context with a condition based on sssd version but that condition is wrong (as of today, no version of sssd provides the fix). Remove the wrong condition so that the test is always expected to fail. Fixes: https://pagure.io/freeipa/issue/9141
|
Link to successful run of |
flo-renaud
added
needs review
|
@flo-renaud Thank you for reporting issue and fixing this. LGTM |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests
TestNonPosixAutoPrivateGroup::test_idoverride_with_auto_private_group
and
TestPosixAutoPrivateGroup::test_gidnumber_not_corresponding_existing_group
are expected to fail until SSSD fixes issues 5988 and 5989.
They currently define an xfail_context with a condition based on
sssd version but that condition is wrong (as of today, no version
of sssd provides the fix).
Remove the wrong condition so that the test is always expected to fail.
Fixes: https://pagure.io/freeipa/issue/9141