New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 389-ds healthcheck output message #6450
Conversation
NACK. This change would break the test when it is run against older 389-ds. We don't need the whole phrase to check, first part of it is unique enough for the comparison. Please change the code so that we only compare the first line.
and not the rest of the output. |
@abbra ack, will fix it |
@ssidhaye if you rebase your branch, the commit https://pagure.io/freeipa/c/94835d19b5a0e0bb2a4043bf8becc54062e5d9ab?branch=master will be picked and should fix the azure issue. |
@ssidhaye thanks for the PR, LGTM. Please remove the temp commit. |
@ssidhaye ping, could you please remove the temp commit and answer the question @flo-renaud asked in #6450 (comment) ? |
I confirm that this patch fixes |
…healthcheck. Previously the message was: "\n\nIn Directory Server, we offer one hash suitable for this " "(PBKDF2_SHA256) and one hash\nfor \"legacy\" support (SSHA512)." "\n\nYour configuration does not use these for password storage " "or the root password storage\nscheme.\n" but now the message is: \n\nIn Directory Server, we offer one hash suitable for this " "(PBKDF2-SHA512) and one hash\nfor \"legacy\" support (SSHA512)." "\n\nYour configuration does not use these for password storage " "or the root password storage\nscheme.\n" PBKDF2_SHA256 has been replaced with PBKDF2-SHA512 Pagure: https://pagure.io/freeipa/issue/9238 Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
@flo-renaud @abbra Sorry I was on PTO. Just removed the temp commit. I will check which branches need this fix add the appropriate labels. @stanislavlevin Thanks for verifying the fix. |
master:
|
With the commit #99a74d7, 389-ds changed the message returned in ipa-healthcheck.
Previously the message was:
"\n\nIn Directory Server, we offer one hash suitable for this " "(PBKDF2_SHA256) and one hash\nfor "legacy" support (SSHA512)." "\n\nYour configuration does not use these for password storage " "or the root password storage\nscheme.\n"
but now the message is:
\n\nIn Directory Server, we offer one hash suitable for this " "(PBKDF2-SHA512) and one hash\nfor "legacy" support (SSHA512)." "\n\nYour configuration does not use these for password storage " "or the root password storage\nscheme.\n"
PBKDF2_SHA256 has been replaced with PBKDF2-SHA512
Pagure: https://pagure.io/freeipa/issue/9238
Signed-off-by: Sumedh Sidhaye ssidhaye@redhat.com