x509: Replace removed register_interface with subclassing #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python-cryptography 38.0 removed `register_interface` decorator: pyca/cryptography@f70e334 Backward compatibility: Cryptography haven't changed the interface of `Certificate` since it was first used by IPA (4.6.0) till cryptography 38.0. cryptography 38.0 (pyca/cryptography@c1b7307) added `tbs_precertificate_bytes` attribute. Fixes: https://pagure.io/freeipa/issue/9160 Signed-off-by: Stanislav Levin <slev@altlinux.org>
|
Tests I was able to do are fine, so backwards compat works.
I got into rpm dependency hell trying to build python3-cryptography-38.0.0 due to some out-of-date rust crates. I couldn't install it with pip either. |
|
Ok I got it to install in pip (-U FTW). It tests out ok. Certs are loadable and while the new API is available and throws a ValueError since the IPA CA doesn't have a SCT list extension. Which is fine. |
rcritten
added
ipa-4-10
|
master:
|
|
@rcritten, thank you for review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-cryptography 38.0 removed
register_interfacedecorator: pyca/cryptography@f70e334Backward compatibility:
Cryptography haven't changed the interface of
Certificatesince it was first used by IPA (4.6.0) till cryptography 38.0.cryptography 38.0 (pyca/cryptography@c1b7307) added
tbs_precertificate_bytesattribute.Fixes: https://pagure.io/freeipa/issue/9160