Differentiate location meaning between host and server #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A host uses Location (nshostlocation) as an optional hint where a host may phsyically be located (e.g. Lab 2). This will result in an attribute in the host entry like: nshostlocation: Lab 2 A server uses location (ipalocation) to identify which DNS location the server is part of (e.g. prague). This will result in an attribute in the server entry like: ipalocation: idnsname=prague,cn=locations,cn=etc,dc=example,dc=test They are completely different animals. https://pagure.io/freeipa/issue/9317 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten
added
trivial
ipa-4-9
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
May 17, 2023
Host location and server location have very different meanings in IPA. ipahost uses 'location' as an optional hint to where the host may be physically located, ipaserever uses location to identify which DNS location the server is part of. This change updates documentation to make attribute description more clear. Surrounding text have been changed to match text style as used in other plugins. This patch is related to: freeipa/freeipa#6840
|
Thank you Rob. I like the updated text. A related PR to update the attribute text in ansible-freeipa has been created to keep consistency (freeipa/ansible-freeipa#1098). |
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
May 30, 2023
Host location and server location have very different meanings in IPA. ipahost uses 'location' as an optional hint to where the host may be physically located, ipaserever uses location to identify which DNS location the server is part of. This change updates documentation to make attribute description more clear. Surrounding text have been changed to match text style as used in other plugins. This patch is related to: freeipa/freeipa#6840
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
May 31, 2023
Host location and server location have very different meanings in IPA. ipahost uses 'location' as an optional hint to where the host may be physically located, ipaserever uses location to identify which DNS location the server is part of. This change updates documentation to make attribute description more clear. Surrounding text have been changed to match text style as used in other plugins. This patch is related to: freeipa/freeipa#6840
|
LGTM. |
|
master:
|
This was referenced Jun 22, 2023
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
Jul 14, 2023
Host location and server location have very different meanings in IPA. ipahost uses 'location' as an optional hint to where the host may be physically located, ipaserever uses location to identify which DNS location the server is part of. This change updates documentation to make attribute description more clear. Surrounding text have been changed to match text style as used in other plugins. This patch is related to: freeipa/freeipa#6840
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
Jul 14, 2023
Host location and server location have very different meanings in IPA. ipahost uses 'location' as an optional hint to where the host may be physically located, ipaserever uses location to identify which DNS location the server is part of. This change updates documentation to make attribute description more clear. Surrounding text have been changed to match text style as used in other plugins. This patch is related to: freeipa/freeipa#6840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A host uses Location (nshostlocation) as an optional hint where a host may phsyically be located (e.g. Lab 2). This will result in an attribute in the host entry like:
nshostlocation: Lab 2
A server uses location (ipalocation) to identify which DNS location the server is part of (e.g. prague). This will result in an attribute in the server entry like:
ipalocation: idnsname=prague,cn=locations,cn=etc,dc=example,dc=test
They are completely different animals.
https://pagure.io/freeipa/issue/9317