Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipa-client-automount install/uninstall with new install states #7100

Closed
wants to merge 3 commits into from
Closed

Fix ipa-client-automount install/uninstall with new install states #7100

wants to merge 3 commits into from

Commits on Jan 9, 2024

  1. Fix ipa-client-automount install/uninstall with new install states 

    Issue 8384 introduced a new installation state for the statestore
to identify when client/server installation is completely finished
rather than relying on has_files().

The problem is that ipa-client-automount may be called during
ipa-client-install and since installation is not complete at that
point the automount install was failing with "IPA client not
configured".

Add a new state, 'automount', to designate that automount installation
is in process. If check_client_configuration() fails it checks to
see if [installation] automount is True. If so it continues with the
installation.

This also addresses an issue where the filestore and statestore are
shared between the client and automount installers but the client
wasn't refreshing state after automount completed. This resulted in
an incomplete state and index file of backed-up files which caused
files to not be restored on uninstall and the state file to be
orphaned.

Fixes: https://pagure.io/freeipa/issue/9487

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
    @rcritten
    rcritten committed Jan 9, 2024
    Copy the full SHA
    b9e7c63 View commit details
    Browse the repository at this point in the history

  2. ipatests: Test client install/uninstall with automount enabled 

    The automount installation was failing. Confirm that it is fixed.

The uninstall was not restoring all files/configuration. Verify
that the index and state files are gone which means that all state
and files were restored.

Fixes: https://pagure.io/freeipa/issue/9487

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
    @rcritten
    rcritten committed Jan 9, 2024
    Copy the full SHA
    44433d7 View commit details
    Browse the repository at this point in the history

  3. ipa-client-automount: Don't use deprecated ipadiscovery.IPADiscovery 

    This class was moved to ipaclient/discovery.py in e6d560a to make
it available to PyPI.

Related: https://pagure.io/freeipa/issue/9487

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
    @rcritten
    rcritten committed Jan 9, 2024
    Copy the full SHA
    6771783 View commit details
    Browse the repository at this point in the history