ipatests: check_subca should be more robust wrt key nickname #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test check_subca is using certutil -L -n nickname or certutil -K -n nickname to find a cert or a key in a database using its nickname. Sometimes the key nickname contains the token (for instance the cert nickname is "caSigningCert cert-pki-ca" but the key nickname is "NSS Certificate DB:caSigningCert cert-pki-ca"), and this make check_subca fail. Rewrite the check_subca method so that it is more robust and able to handle nicknames with token:nickname. Fixes: https://pagure.io/freeipa/issue/9534 Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>
|
The test is failing in a different step: add a subca on master, disable the subca on replica, delete the subca on replica. I opened dogtagpki/pki#4669 to track the issue on PKI side. |
|
dogtagpki/pki#4669 has been fixed and we are now hitting a different issue. Running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test check_subca is using certutil -L -n nickname
or certutil -K -n nickname to find a cert or a key in a database
using its nickname.
Sometimes the key nickname contains the token (for instance
the cert nickname is "caSigningCert cert-pki-ca" but the key
nickname is "NSS Certificate DB:caSigningCert cert-pki-ca"),
and this make check_subca fail.
Rewrite the check_subca method so that it is more robust and
able to handle nicknames with token:nickname.
Fixes: https://pagure.io/freeipa/issue/9534