Internalize ResqueStatus, fix deprecated tests. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMY3
force-pushed
the
internalize-resque-status
branch
from
d240a26
to
9375df3
Compare
TheMY3
force-pushed
the
internalize-resque-status
branch
from
9375df3
to
56941dd
Compare
TheMY3
commented
May 5, 2022
| - uses: "ramsey/composer-install@v2" | ||
| with: | ||
| composer-options: "--ignore-platform-reqs --optimize-autoloader" | ||
| - name: Build the stack |
There was a problem hiding this comment.
Через docker compose как-то проще за всем следить, и redis теперь нужен,
| @@ -622,7 +621,7 @@ public function resume() | |||
| $options->allOption = 'Resume all workers'; | |||
| $options->selectMessage = 'Worker to resume'; | |||
| $options->actionMessage = 'resuming'; | |||
| $options->workers = call_user_func([$this->ResqueStatus, 'getPausedWorker']); | |||
| $options->workers = call_user_func([$this->ResqueStatus, 'getPausedWorkers']); | |||
There was a problem hiding this comment.
Автозамена, так бы убрал call_user_func, не знаю зачем он его везде использовал.
Comment on lines
+12
to
+14
| public const WORKER_KEY = 'ResqueWorker'; | ||
| public const SCHEDULER_WORKER_KEY = 'ResqueSchedulerWorker'; | ||
| public const PAUSED_WORKER_KEY = 'PausedWorker'; |
There was a problem hiding this comment.
Тут сразу и рефакторинг небольшой сделал, публичные т.к. в тестах юзаются.
| [$this->stringContains($datas[0]['queue'])], | ||
| )->willReturnOnConsecutiveCalls(0, 9, 10, 3); | ||
|
|
||
| $this->output |
There was a problem hiding this comment.
С N раза решил взяться и аккуратно переписать его, получилось, теперь нет больше предупреждений.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.