Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in page for admin site not rate limited #2251

Closed
mlissner opened this issue Aug 9, 2022 · 0 comments · Fixed by #2252
Closed

Log in page for admin site not rate limited #2251

mlissner opened this issue Aug 9, 2022 · 0 comments · Fixed by #2252
Labels

Comments

@mlissner
Copy link
Member

mlissner commented Aug 9, 2022

A big part of me really doesn't care about this, BUT it's true that it kind of matters and I think it's finally the last place where folks need to be ratelimited (ha, ha, we'll see).

Our VDP has yielded a couple good vulnerabilities (including one in Python itself), but I do tire of all the ratelimit testers.

Anyhow, the easiest solution is to just remove the admin log in page and redirect it to our regular one (which is rate limited). See here for a solution that's pretty darned simple:

https://stackoverflow.com/a/61946707/64911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant