Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Add continuous integration using Github actions #271

Merged
merged 17 commits into from
Nov 10, 2022

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Nov 10, 2022

This PR solves multiple issues related to the implementation of continuous integration.

  • Remove references to Travis CI ( in readme.md and testing.md) and also delete the configuration file ( travis.yml).
  • Adds Puppeteer as a dev dependency to use its Chromium binary to run the tests in headless mode.
  • Update the configuration file used by Karma to change the default browser used to run the tests.
  • Bump Karma from 6.3.2 to 6.4.1 to avoid getting DeprecationWarning while running the test suite.

This changes should close Fix continuous integration#310.

@ERosendo ERosendo marked this pull request as draft November 10, 2022 01:18
@ERosendo ERosendo marked this pull request as ready for review November 10, 2022 01:32
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A couple little tweaks, please.

CHANGES.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
ERosendo and others added 2 commits November 10, 2022 19:42
Reformat the list of changes included in this PR.

Co-authored-by: Mike Lissner <mike@free.law>
- Wait until the next release to bump the version
@mlissner mlissner merged commit 82de664 into main Nov 10, 2022
@mlissner mlissner deleted the 310-fix-continuous-integration branch November 10, 2022 23:51
@mlissner
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Fix continuous integration
2 participants