Fix flaky on Test: actionBlockStopsWhenMovedToAnotherState #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
approved these changes
May 9, 2023
|
yea, I saw a few more. Would fix them once they became flaky (I actually started becoming a bit paranoid: "why are the others not flaky?" Maybe, also what I do here in this PR is wrong 😑 hahaha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the previous implementation was that it can take a few ms for FlowRedux to cancel the
on<Action> {...}block. therefore we have introduced thedelay(100)but since we didadvanceUntilIdle()andrunCurrent()on theTestDispatcherit skips the delay and it was sometimes still too fast (so cancelation happened afterward). That resulted in a flaky test.Now I rephrased the test towards "Block is canceled within 10 milliseconds after having moved to another state"