adjust version code logic from v24 on #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalalawqati
approved these changes
Nov 7, 2023
plugins/src/main/kotlin/com/freeletics/gradle/monorepo/tasks/ComputeVersion.kt
Show resolved
Hide resolved
plugins/src/main/kotlin/com/freeletics/gradle/monorepo/tasks/ComputeVersion.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From version 24.1.0 on (next year) the version code will move the part for the minor version one digit to the right. This leaves an unused
0between the minor version and the major version and is purely for readability purposes.Examples:
24010000->2400100024100000->2401000024240000->2402400024440000->24044000For regular release builds the last 2 digits are used for patches (both beta patches and hotfix) and the 100 digit is unused.
The logic for untagged builds which we use for nightly builds is adjusted to use the last 3 digits. The first of those 3 is still used for the day of week. Since that leaves only 2 digits and 99 commits per release/week is not enough we now use the time of day there. This allows to still do multiple "nightly" builds per day for testing purposes. The only limitation is that you can only do one every 15 minutes but that is fine for one-off tests.