update to Anvil 2.4.4 and use new TopLevelFunctionReference #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2023
gabrielittner
force-pushed
the
anvil-2.4.4
branch
from
255c1d0
to
8093ad4
Compare
gabrielittner
force-pushed
the
anvil-2.4.4
branch
from
8093ad4
to
9c6bbb2
Compare
gabrielittner
commented
Jan 27, 2023
Comment on lines
-52
to
+57
| val compilation = KotlinCompilation().apply { | ||
| configure() | ||
| val compilation = AnvilCompilation().apply { | ||
| configureAnvil() | ||
| kotlinCompilation.configure() | ||
| useIR(true) |
There was a problem hiding this comment.
This is a helper from Anvil which was previously not working for us. It has its own configureAnvil method so that we don't need our own below anymore
gabrielittner
commented
Jan 27, 2023
Comment on lines
-579
to
+597
| public val testClass2: TestClass2 | ||
| public val test: TestClass2 |
There was a problem hiding this comment.
This changed because we are now using the parameter name here instead of a name derived from the class.
snappdevelopment
approved these changes
Jan 27, 2023
Comment on lines
517
to
+523
| name = "testClass", | ||
| className = ClassName("com.test", "TestClass"), | ||
| typeName = ClassName("com.test", "TestClass"), | ||
| ), | ||
| ComposableParameter( | ||
| name = "test", | ||
| className = ClassName("com.test.other", "TestClass2"), | ||
| ) | ||
| typeName = ClassName("com.test.other", "TestClass2"), | ||
| ), |
There was a problem hiding this comment.
I think we could remove one of the two. I used two to make sure it is possible to inject multiple parameter, but since we are testing Set and Map as well, this is already covered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Kotlin to 1.8.0, Compose Compiler to 1.4.0 and Anvil to 2.4.4. Anvil now offers a
TopLevelFunctionReferenceabstraction which allows us to delete our own copy and improves parameter parsing over what we are currently doing. The latter automatically gives us support for objects with type parameters injecting into composable functions. Our tests that run Anvil are also using Anvil's helper for the set up now, I think the issue before was in incompatibility with the kotlin-compile-testing version wer were using.Closes #256