Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing estimate segment lengths #571

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

aaroncherian
Copy link
Collaborator

Removing estimate skeleton segment lengths from the pipeline (we don't use the function anymore)

@philipqueen
Copy link
Collaborator

This looks good to me!

For the stuff that was commented out, we can also just remove it. If we need it for any reason, it's in the git history

@aaroncherian
Copy link
Collaborator Author

Oh yeah totally agree. Honestly the only reason was really for the laziness of my future self lol. All the commented stuff is DataSaver related - and I'm still unsure as to the role of DataSaver vs. the save_data function - but I thought there might be a chance that we'd want to do a 1 to 1 replacement of saving out the previous segment connections with the incoming segment connections. So I commented it out to easily bring it back if necessary without having to check the git history. Again, just laziness lol.

@philipqueen philipqueen added the ready for review Pull request is ready for final review label Apr 12, 2024
@aaroncherian aaroncherian merged commit cb72f4b into main Apr 16, 2024
3 checks passed
@aaroncherian aaroncherian deleted the aaron/remove_estimate_skeleton_segment_lengths branch April 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants