Html5 audio and video tag #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 15, 2010 14:37
|
-nextgens- what #323 does is to allow both audio and video tags (not in a way that's consistent with the rest of the code) without any filtering |
| emptyStringArray, | ||
| new String[] { "src", "poster" }, | ||
| emptyStringArray, | ||
| new String[] {"preload", "loop", "controls"})); |
There was a problem hiding this comment.
This is wrong, preload is not a "Boolean attribute" (in the sense of 879cb91, e.g. attribute x only valid without value (<tag …="…" x>) or with value equal to the attribute name (<tag …="…" x="x">). preload="preload" is not even valid.
|
You have rescued these from bitrot for review! Thank you! |
|
close because there‘s already better code in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for the HTML5 audio and video tag. Pull-request created to track progress.