-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html5 audio and video tag #323
Conversation
-nextgens- what #323 does is to allow both audio and video tags (not in a way that's consistent with the rest of the code) without any filtering |
emptyStringArray, | ||
new String[] { "src", "poster" }, | ||
emptyStringArray, | ||
new String[] {"preload", "loop", "controls"})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, preload
is not a "Boolean attribute" (in the sense of 879cb91, e.g. attribute x
only valid without value (<tag …="…" x>
) or with value equal to the attribute name (<tag …="…" x="x">
). preload="preload"
is not even valid.
You have rescued these from bitrot for review! Thank you! |
close because there‘s already better code in now. |
support for the HTML5 audio and video tag. Pull-request created to track progress.