Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented simulation launcher for network version #967

Merged
merged 23 commits into from
Jan 23, 2024

Conversation

netsirius
Copy link
Collaborator

@netsirius netsirius commented Jan 21, 2024

Changes summary

This pull request adds network mode to the test launcher, enabling simulations in a more realistic network environment. Initially uses local TCP sockets, laying the groundwork for future expansion to more generic settings, including cloud environments.

Key Implementation Details

  • Setup and Initialization: Completed initial setup of the web server and node configuration, establishing the core framework for network simulation.
  • Node and Server Interaction: Configured nodes to retrieve peer settings from the server, preparing the server to manage and dispatch events to peers.
  • P2P Node Execution: Implemented with a new event generator and using the MemoryContractHandler.
  • Connectivity Achievement: Successfully established connections with nodes. However, an issue has been identified involving the discrepancy between P2P peer IDs and the peer IDs we generate. Due to potential shift from current P2P library, this issue is not prioritized for immediate fix.

Copy link
Collaborator

@iduartgomez iduartgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things, looking good

crates/core/src/client_events.rs Outdated Show resolved Hide resolved
crates/core/src/ring.rs Show resolved Hide resolved
crates/fdev/src/testing/multiple_process.rs Outdated Show resolved Hide resolved
@iduartgomez iduartgomez merged commit b139488 into freenet:main Jan 23, 2024
3 of 4 checks passed
@iduartgomez iduartgomez deleted the 186677238-launch-network-tests branch October 5, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants