Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GASEOUS_LABEL text #2177

Closed
Oberlus opened this issue Jun 24, 2018 · 2 comments
Closed

Change GASEOUS_LABEL text #2177

Oberlus opened this issue Jun 24, 2018 · 2 comments
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:art music text assets The Issue/PR deals with creating, modifying or verifying game assets. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.

Comments

@Oberlus
Copy link
Contributor

Oberlus commented Jun 24, 2018

Sly in their native environment has a special effect (-50% population, target population scaling priority) so that before-scaling effects produce values equivalent to a medium size planet instead of the default 6 size of the planet. This effect does no apply in the rest of planets (so once a Sly can colonise a hostile env. planet, it will have the same population numbers than any other AVERAGE_POPULATION species with same tech.
The point is the text for that effect on GGs is "Bad Environment", which is confusing for the native environment of a species.

Dilvish suggested "Crushing Gravity". I'm not convinced (I expect gasbags to require that gravity).
Another alternative could be "Gas Giant Environment".

I want to note that having habitable size 4 for GGs and removing the -50% population effect would yield roughly similar population values than current implementation (without any other change) and render unnecessary the GASEOUS_LABEL.

Discusion in http://www.freeorion.org/forum/viewtopic.php?f=28&t=10995

@geoffthemedio geoffthemedio added component:art music text assets The Issue/PR deals with creating, modifying or verifying game assets. category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. labels Jun 25, 2018
@Vezzra Vezzra added this to the v0.4.8 (optional) milestone Jun 25, 2018
@Vezzra
Copy link
Member

Vezzra commented Jun 25, 2018

As this is essentially a confusing/misleading label/text, I think we can consider any patch which changes that close enough to a "fix" to allow it into the release (especially since such a fix is going to be of the very simple kind 😉).

@Vezzra Vezzra added the status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug. label Jun 29, 2018
@Vezzra
Copy link
Member

Vezzra commented Jun 29, 2018

Fixed by #2181.

@Vezzra Vezzra closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:art music text assets The Issue/PR deals with creating, modifying or verifying game assets. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Projects
None yet
Development

No branches or pull requests

3 participants