Fails to build with Boost 1.69 (develop snapshot)

[jbeich]

After boostorg/boost#189 build fails, see error log and missing files

CMake Error at /usr/local/share/cmake/Modules/FindBoost.cmake:2049 (message):
  Unable to find the requested Boost libraries.

  Boost version: 1.69.0

  Boost include path: /usr/local/include

  Could not find the following Boost libraries:

          boost_signals

Note, according to Boost calendar 1.69 release is planned sometime in December.

[o01eg]

Looks like it will affect 0.4.8 as well.

[geoffthemedio]

I thought the signals dependency was removed some time ago. Does this just require a change to a CMakeLists.txt ? Perhaps to change a default from signals to signals2 ?

[Vezzra]

Has this been fixed sufficiently by #2310? Can we close it as resolved?

[geoffthemedio]

Seemingly yes

#2310 (comment)

[jbeich]

After boostorg/serialization@af46ac2da3e9 (post-Beta1) build fails. See error log. Including <string> just after <memory> in combat/CombatEvent.h appears to be enough to fix it.

In file included from combat/CombatEvent.cpp:1:
combat/CombatEvent.h:42:25: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
    virtual std::string CombatLogDetails(int viewing_empire_id) const
                        ^
/usr/include/c++/v1/iosfwd:193:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS basic_string;
                               ^
In file included from combat/CombatEvent.cpp:1:
combat/CombatEvent.h:43:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
    { return std::string(""); }
             ^
/usr/include/c++/v1/iosfwd:193:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS basic_string;
                               ^

[geoffthemedio]

As in that pull request?