Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for confirmation to leave without sending orders in the multiplayer game #2551

Closed
o01eg opened this issue Sep 14, 2019 · 3 comments
Closed

Ask for confirmation to leave without sending orders in the multiplayer game #2551

o01eg opened this issue Sep 14, 2019 · 3 comments
Labels
category:feature The Issue/PR describes or implements a new game feature. component:UI The Issue/PR deals with the game user interface, graphical or other. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Milestone
v0.4.9

Comments

@o01eg
Copy link
Contributor

o01eg commented Sep 14, 2019

Environment

  • FreeOrion Version: master
  • Fetched as
    • Binary release
    • Weekly development build
    • Compiled from source

Description

In the multiplayer game the player could forgot to send his orders before close client: https://www.freeorion.org/forum/viewtopic.php?p=97201#p97201
I suppose there should be some confirmation to ensure player want to disconnect from the game without set his empire to ready.

Expected Result

In the multiplayer game show confirmation dialog to ask if the player want to leave the game if his empire is unready.
@o01eg o01eg added category:feature The Issue/PR describes or implements a new game feature. component:UI The Issue/PR deals with the game user interface, graphical or other. labels Sep 14, 2019
@o01eg o01eg added this to the Next Release milestone Sep 14, 2019
@Vezzra Vezzra modified the milestones: Next Release, v0.4.9 Sep 22, 2019
@geoffthemedio geoffthemedio removed this from the v0.4.9 milestone Oct 3, 2019
@geoffthemedio
Copy link
Member

This is a would-be-nice but not a requirement for v0.4.9, I think.

@Vezzra
Copy link
Member

Vezzra commented Oct 4, 2019

Ok

swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 14, 2019
@swaqvalley
Issue freeorion#2551, prompt user when leaving multiplayer game witho…
8adbd75 
…ut setting status to ready
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 14, 2019
@swaqvalley
Issue freeorion#2551, prompt user when leaving multiplayer game witho…
3981e1c 
…ut setting status to ready.
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 14, 2019
@swaqvalley
Issue freeorion#2551, English message for prompt
1706630
@swaqvalley swaqvalley mentioned this issue Oct 14, 2019
Merged
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 14, 2019
@swaqvalley
Issue freeorion#2551, prompt user when leaving multiplayer game witho…
a44032c 
…ut setting status to ready.
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 15, 2019
@swaqvalley
Issue freeorion#2551, prompt user when leaving multiplayer game witho…
d57e42e 
…ut setting status to ready.
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 15, 2019
@swaqvalley
Issue freeorion#2551, prompt user when leaving multiplayer game witho…
87c9a12 
…ut setting status to ready.
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 17, 2019
@swaqvalley
fixup! Issue freeorion#2551, prompt user when leaving multiplayer gam…
8df33c2 
…e without setting status to ready.
swaqvalley added a commit to swaqvalley/freeorion that referenced this issue Oct 17, 2019
@swaqvalley
Issue freeorion#2551, prompt user when leaving multiplayer game witho…
019f24f 
…ut setting status to ready.
geoffthemedio added a commit that referenced this issue Oct 19, 2019
@geoffthemedio
Merge pull request #2594 from swaqvalley/issue2551
ca236bb 
Issue #2551 changes
@o01eg o01eg added this to the v0.4.9 milestone Nov 17, 2019
@o01eg
Copy link
Contributor Author

o01eg commented Nov 17, 2019

It looks like it was fixed in #2594

@geoffthemedio geoffthemedio added the status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug. label Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:feature The Issue/PR describes or implements a new game feature. component:UI The Issue/PR deals with the game user interface, graphical or other. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Projects
None yet
Milestone
v0.4.9
Development

No branches or pull requests
3 participants
@o01eg @Vezzra @geoffthemedio