Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change asteroid building requirements. #1343

Conversation

LGM-Doyle
Copy link
Contributor

This PR makes two changes to the requirements for the asteroid buildings:

  • requires that the asteroid shipyard be build in a system with an empire owned shipyard.
  • allows the asteroid reformation processor to be build on any asteroid belt, without an asteroid shipyard.

It more clearly delineates the usage of the two buildings.

I never realized that the asteroid reformation processor, created armor parts that you could use anywhere it was supply connected. I knew that it was an extension to the asteroid shipyard and assumed that it needed to be in the same system as the shipyard using the parts.

With this PR the asteroid shipyard is tied to a basic shipyard, like the other hull lines shipyard extensions.

The asteroid processor clearly creates a freespace resource that can be used anywhere.

@LGM-Doyle LGM-Doyle added category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. labels Feb 19, 2017
@Vezzra Vezzra added this to the post v0.4.7 milestone Feb 24, 2017
@Vezzra
Copy link
Member

Vezzra commented Feb 24, 2017

@LGM-Doyle, to avoid a design discussion here in the comment section of your PR, can you open a corresponding thread on the Other Game Design forum and add a link to it here?

In the opening post of the thread explain why you think this change should be done, so we can start the discussion there.

@LGM-Doyle
Copy link
Contributor Author

I'm closing this since I originally considered this a bug fix and not a content change.

@LGM-Doyle LGM-Doyle closed this Sep 3, 2017
@LGM-Doyle LGM-Doyle deleted the change_asteroid_building_requirements branch September 3, 2017 15:50
@Vezzra Vezzra modified the milestones: v0.4.8, Gateway to the Void Sep 15, 2017
@Vezzra Vezzra added the status:invalid The Issue is not classified as a formal valid Issue report or applicable PR. label Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. status:invalid The Issue is not classified as a formal valid Issue report or applicable PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants