Fix crash caused by erasing map elements while iterating in System.cpp. #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGM-Doyle
added
category:bug
|
looks reasonable |
|
And just for the records, it indeed fixed the issue, at least on my system. The save game provided in that forum thread no longer crashes when executing the next turn. 👍 |
Vezzra
added
the
status:merged
LGM-Doyle
deleted the
fix_bug_osx_intermitent_crash_when_experimetors_active
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix the crash reported in the forum, where after the Experimentors are active the game crashes on OSX.
In System::Copy there is for loop iterating over the map of starlanes and deleting elements. It does not account for the deleted elements while iterating so it could step into nowhere.
This PR fixes that problem. However, since I can't replicate the crash it may not fix the crash.