New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow invasion through planet shields #1475
base: master
Are you sure you want to change the base?
Conversation
…each ship reduced if planet is shielded.
This would need some serious balancing thought and probably significant AI work (they're having enough problems in this area until recently anyway): we deliberately added the 1 point shield amount to all colonies and outposts not that long ago and the basic "have shields = no invasion" is a nice simple mechanic. |
@@ -1643,7 +1645,7 @@ void SidePanel::PlanetPanel::Refresh() { | |||
bool at_war_with_me = !mine && (populated || (has_owner && Empires().GetDiplomaticStatus(client_empire_id, planet->Owner()) == DIPLO_WAR)); | |||
|
|||
bool being_invaded = planet->IsAboutToBeInvaded(); | |||
bool invadable = at_war_with_me && !shielded && visible && !being_invaded && !invasion_ships.empty(); | |||
bool invadable = at_war_with_me && /*!shielded && visible && */ !being_invaded && !invasion_ships.empty(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you really mean to take out the visibility requirement?
This is an excellent example for a PR that should have an accompanying thread on one of the design forums, to avoid having the design discussion starting here in the comment section. The idea definitely merits serious consideration and discussion, but I'll wait for the accompanying thread to be opened to add my 2c. 😃 |
Link to design discussion on the forum: |
Did this ever came to a conclusion? This branch is now over a year old. |
No, but like #1091, we might at some point get back to this. |
Allows invasion of planets that have shields, but with reduce effective troop numbers as the level of shielding increases. Could possibly be used as a feature or ability of a species, government policy, or type of troop pod.