Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow invasion through planet shields #1475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geoffthemedio
Copy link
Member

Allows invasion of planets that have shields, but with reduce effective troop numbers as the level of shielding increases. Could possibly be used as a feature or ability of a species, government policy, or type of troop pod.

@geoffthemedio geoffthemedio added category:feature The Issue/PR describes or implements a new game feature. component:game mechanic The Issue/PR deals with the currently used or planned game mechanics. status:testing requested The Implementation can't be tested sufficiently by the developer and require support. status:work in progress The PR contains some implementation but isn't ready for merging onto the main development branch. labels Apr 8, 2017
@geoffthemedio geoffthemedio added this to the post v0.4.7 milestone Apr 8, 2017
@MatGB
Copy link
Member

MatGB commented Apr 8, 2017

This would need some serious balancing thought and probably significant AI work (they're having enough problems in this area until recently anyway): we deliberately added the 1 point shield amount to all colonies and outposts not that long ago and the basic "have shields = no invasion" is a nice simple mechanic.

@@ -1643,7 +1645,7 @@ void SidePanel::PlanetPanel::Refresh() {
bool at_war_with_me = !mine && (populated || (has_owner && Empires().GetDiplomaticStatus(client_empire_id, planet->Owner()) == DIPLO_WAR));

bool being_invaded = planet->IsAboutToBeInvaded();
bool invadable = at_war_with_me && !shielded && visible && !being_invaded && !invasion_ships.empty();
bool invadable = at_war_with_me && /*!shielded && visible && */ !being_invaded && !invasion_ships.empty();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you really mean to take out the visibility requirement?

@Vezzra
Copy link
Member

Vezzra commented Apr 8, 2017

This is an excellent example for a PR that should have an accompanying thread on one of the design forums, to avoid having the design discussion starting here in the comment section.

The idea definitely merits serious consideration and discussion, but I'll wait for the accompanying thread to be opened to add my 2c. 😃

@Vezzra
Copy link
Member

Vezzra commented Apr 9, 2017

Link to design discussion on the forum:

http://www.freeorion.org/forum/viewtopic.php?f=6&t=10500

@Vezzra Vezzra modified the milestones: v0.4.8 (mandatory), post 0.4.8 Oct 29, 2017
@adrianbroher
Copy link
Contributor

Did this ever came to a conclusion? This branch is now over a year old.

@Vezzra
Copy link
Member

Vezzra commented Apr 15, 2018

No, but like #1091, we might at some point get back to this.

@geoffthemedio?

@Vezzra Vezzra removed this from the Next Release milestone Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:feature The Issue/PR describes or implements a new game feature. component:game mechanic The Issue/PR deals with the currently used or planned game mechanics. status:testing requested The Implementation can't be tested sufficiently by the developer and require support. status:work in progress The PR contains some implementation but isn't ready for merging onto the main development branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants