Add options to disable disclosure of galaxy seed #2845
Conversation
o01eg
added
category:feature
util/SerializeMultiplayerCommon.cpp
Outdated
| ar & BOOST_SERIALIZATION_NVP(m_seed) | ||
| & BOOST_SERIALIZATION_NVP(m_size) | ||
| if (Archive::is_saving::value && m_encoding_empire != ALL_EMPIRES && (!GetOptionsDB().Get<bool>("network.server.publish-seed"))) { | ||
| std::string dummy = "hidden"; |
There was a problem hiding this comment.
Is this "hidden" text meant to be shown to the player on the galaxy info pedia page or multiplayer lobby? If so, there shouldn't be localized text in the source code...
There was a problem hiding this comment.
I'm not sure what to place here as any localization will happen on the server side with some default language instead of client side. Maybe send "-" or some sign to the client?
There was a problem hiding this comment.
Unless an empty string has already another special meaning use that and let the client handle the seed representation.
There was a problem hiding this comment.
In the client UI, setting an empty seed sets it to generate a random seed. The universe generation also treats an empty seed as a sign to generate a random one server-side. But neither of those mean an empty seed can't be sent back to the client later...
There was a problem hiding this comment.
So I suppose empty seed is fine to send to the client.
Vezzra
added
the
status:merged
Fixes #2820