Make COMBAT_TARGETS_PLANET_WITH_DEFENSE macro consider infrastructure #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geoffthemedio As Oberlus playtested this and it is more consistent with the c++ backend, please merge (i think else the slow server game gets delayed by two weeks) |
o01eg
reviewed
Apr 15, 2020
| Not Defense high = 0 | ||
| Not Shield high = 0 | ||
| Not Defense high = 0 | ||
| Not Construction high = 0 |
There was a problem hiding this comment.
Does construction somehow affect it?
There was a problem hiding this comment.
This way it mimics the way it is done in the backend. So the answer must be yes.
There was a problem hiding this comment.
Yes in the past it was too messy to combine regeneration for defense and shield for triggering combat with the usual balance and intended feature (zero defense and zero shields should be possible on a colony). So we reused the unused construction for triggering combat by ensuring minimum construction one (on colonies).
geoffthemedio
added
category:bug
geoffthemedio
added
the
status:merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2488 as suggested by @agrrr3 in this post.
Tested with mass drivers against an Acirema HW, Furthest HW with Moderate Tech Special, and a Gysache AI HW without Planetary Defense Regeneration.