removed the left-click dependence from the ProductionQueue quantity ... #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd block size dropdowns, so they are compatible with adjustment via mousewheel
|
This version doesn't have the crash I was getting, so should be fine to commit. |
Vezzra
added
the
category:refactoring
TheSilentOne1
pushed a commit
to TheSilentOne1/freeorion
that referenced
this pull request
Sep 29, 2015
…nd block size dropdowns, so they are compatible with adjustment via mousewheel Closes freeorion#288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and block size dropdowns, so they are compatible with adjustment via mousewheel.
This seems to work fine for me, but apparently some similar type change had caused crashes on Windows (reported here http://www.freeorion.org/forum/viewtopic.php?p=80095#p80095) so I'm putting this in as a PR for testing.
I'll also note that it looks to me like some additional cleanup is probably possible, eliminating a number of the custom attributes (I'm thinking amOn, prevQuant and prevBlocksize), but I'm leaving that for later.