Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite ship design with same ID #2913

Merged
merged 1 commit into from Apr 30, 2020
Merged

Don't overwrite ship design with same ID #2913

merged 1 commit into from Apr 30, 2020

Conversation

o01eg
Copy link
Contributor

@o01eg o01eg commented Apr 30, 2020

As ship design is referenced by its ID from production queue, changes here could lead to
incorrect ship production.

Fixes #2883 in terms of forbidding change ship design for ID. It doesn't solves issue which leads to ID collision.

@o01eg
Don't overwrite ship design with same ID.
cafcbf2 
As ship design is referenced by its ID from production queue changes here could lead to
incorrect ship production.
@o01eg o01eg added category:bug The Issue/PR describes or solves a perceived malfunction within the game. priority:high The Issue/PR is very urgent or important and should be addressed/finished as soon as possible. labels Apr 30, 2020
@o01eg o01eg added this to the v0.4.10 milestone Apr 30, 2020
@o01eg o01eg self-assigned this Apr 30, 2020
@geoffthemedio geoffthemedio merged commit f8d1c2c into freeorion:master Apr 30, 2020
@geoffthemedio geoffthemedio added the status:merged All relevant commits of this PR were merged into the master development branch. label Apr 30, 2020
@swaqvalley swaqvalley mentioned this pull request May 1, 2020
Closed
@o01eg o01eg deleted the no-overwrite-ship-design branch May 1, 2020 06:10
@o01eg o01eg added the component:internal The Issue/PR deals with any project component that has no explicit `component` label. label May 1, 2020
@Vezzra Vezzra removed the priority:high The Issue/PR is very urgent or important and should be addressed/finished as soon as possible. label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffthemedio geoffthemedio Awaiting requested review from geoffthemedio

Assignees

@o01eg o01eg

Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:internal The Issue/PR deals with any project component that has no explicit `component` label. status:merged All relevant commits of this PR were merged into the master development branch.
Projects
None yet
Milestone
v0.4.10
Development

Successfully merging this pull request may close these issues.

Adding a new ship design replaces an existing one instead
3 participants
@o01eg @Vezzra @geoffthemedio