Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay SINGULARITY_GEN, reduce ART_BLACK_HOLE build time #2940

Merged

Conversation

Oberlus
Copy link
Contributor

@Oberlus Oberlus commented May 11, 2020

Makes Singularity Generation tech require Temporal Mechanics and reduces build time or Artificial Black Hole (from 10 to 6), so that empires with a nearby Black Hole with planets doesn't have a great advantage over empires that must research Artificial Black Hole.

Forum thread.

@Vezzra Vezzra added category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. labels May 13, 2020
@Vezzra
Copy link
Member

Vezzra commented May 13, 2020

@freeorion/ai-team, can you comment on what adjustments to the AI scripts might be required by these changes?

@geoffthemedio
Copy link
Member

@freeorion/ai-team bump?

@geoffthemedio
Copy link
Member

@Cjkjvfnby perhaps?

@Morlic-fo
Copy link
Contributor

Minimum change is to prevent incorrect fast-tracking after Solar Orbital Generation

if (fo.currentTurn() > 50 and len(AIstate.empireStars.get(fo.starType.blackHole, [])) != 0 and
aistate.character.may_research_tech_classic("PRO_SINGULAR_GEN") and not tech_is_complete(Dep.PRO_SINGULAR_GEN) and
tech_is_complete(Dep.PRO_SOL_ORB_GEN)):

Replace tech_is_complete(Dep.PRO_SOL_ORB_GEN) with tech_is_complete("LRN_EVERYTHING")

@Oberlus Oberlus force-pushed the RebalanceSingularityGeneration branch from 15c27c9 to 42def4f Compare June 7, 2020 14:07
@Oberlus
Copy link
Contributor Author

Oberlus commented Jun 7, 2020

Rebased, included Morlic's change, and ready for merge.

@Oberlus Oberlus force-pushed the RebalanceSingularityGeneration branch from 42def4f to 6b4fc86 Compare June 7, 2020 14:28
@geoffthemedio geoffthemedio merged commit 88ee0c8 into freeorion:master Jun 8, 2020
@geoffthemedio geoffthemedio added the status:merged All relevant commits of this PR were merged into the master development branch. label Jun 8, 2020
@geoffthemedio
Copy link
Member

Intended for v0.4.10 ?

@Oberlus
Copy link
Contributor Author

Oberlus commented Jun 9, 2020

Intended for v0.4.10 ?

Much preferably.
Not having it is not gamebreaking in single player. It's mostly intended to level gameplay in multiplayer.

@geoffthemedio geoffthemedio added the status:cherry-pick for release The PR should be applied to the currently open release branch. label Jun 9, 2020
@geoffthemedio geoffthemedio added this to the v0.4.10 milestone Jun 9, 2020
@Oberlus Oberlus deleted the RebalanceSingularityGeneration branch June 9, 2020 09:43
@Vezzra Vezzra removed the status:cherry-pick for release The PR should be applied to the currently open release branch. label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. status:merged All relevant commits of this PR were merged into the master development branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants