Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of fixes for Flathub submission #3146

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Collection of fixes for Flathub submission #3146

merged 2 commits into from
Aug 26, 2020

Conversation

Siosm
Copy link
Contributor

@Siosm Siosm commented Aug 22, 2020

No description provided.

@geoffthemedio geoffthemedio added component:deployment The Issue/PR deals with the deployment process or distribution packages. category:bug The Issue/PR describes or solves a perceived malfunction within the game. labels Aug 22, 2020
@@ -38,4 +38,18 @@
<image width="1600" height="900" type="source">https://www.freeorion.org/screenshots/FreeOrion_ResearchScreen.png</image>
</screenshot>
</screenshots>
<releases>
<release version="0.4.10" date="2020-07-26"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these dates based on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the dates from each release tag.

@Siosm
Copy link
Contributor Author

Siosm commented Aug 26, 2020

I have updated this PR to add the violence rating and split the screenshot request into another PR. This should be ready for another review.

@geoffthemedio
Copy link
Member

geoffthemedio commented Aug 26, 2020

I have updated this PR to add the violence rating

I had a look at the OARS site, and I'm really uncertain about how to apply the ratings to FreeOrion... Or rather, they mostly don't seem to apply.

For example, it refers to graphic depictions of "fictional characters depicted in an animated film or a comic strip" or "realistic characters" or "fantasy characters" in situations / doing things.

FreeOrion just has text saying, in effect, "there was a battle here" with some numbers. There are certainly no "characters" involved.

The wording of "bloodshed" is more general, but at most "mild" or "unrealistic bloodshed" seems applicable.

The discrimination categeory might apply, though it's not clear if "race" applies to fantasy but sentient "species". There are "Concentration Camps" in-game so it's probably a fair label to apply, even if it's seemingly out of the context the categorization was intended for.

So maybe

  <content_rating type="oars-1.1">
    <content_attribute id="violence-bloodshed">mild</content_attribute>
    <content_attribute id="language-humor">mild</content_attribute>
    <content_attribute id="language-discrimination">intense</content_attribute>
    <content_attribute id="social-chat">intense</content_attribute>
  </content_rating>

@Siosm
Copy link
Contributor Author

Siosm commented Aug 26, 2020

Thanks for the context. I wasn't really sure myself how much to rate each. Updated with your changes.

@geoffthemedio geoffthemedio merged commit 3e8644e into freeorion:master Aug 26, 2020
@geoffthemedio geoffthemedio added the status:merged All relevant commits of this PR were merged into the master development branch. label Aug 26, 2020
@geoffthemedio geoffthemedio added this to the v0.5 milestone Aug 26, 2020
@Siosm Siosm deleted the flathub-fixes branch August 26, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:deployment The Issue/PR deals with the deployment process or distribution packages. status:merged All relevant commits of this PR were merged into the master development branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants