Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the feature to resurrect extinct species found in ancient ruins… #340

Closed
wants to merge 3 commits into from

Conversation

Deepsloth
Copy link
Contributor

… with the Xenoresurrection Lab.

@Deepsloth
Copy link
Contributor Author

Information: http://www.freeorion.org/forum/viewtopic.php?f=15&t=6570&start=26

AI doesn't need any immediate updates, but should use the building in the future (and then the Banforo will need a little adjustment for their light sensivity).

A Banfo looks like a teddy bear made of white stone with two large black crystal eyes. It's likely that the Banforo species was artificially created, but information that could show proof was lost in history. The eyes are their most important organs, not only do they serve for perception, but also for communication by showing light patterns around their frames. Banforo can distinguish colors and patterns of even very dim light, as well as focus on light sources far away. Very bright light on the other hand is very hard on their eyes and disturbs their communication. Thus the evening is the favorite time for the Banforo and a defining ritual of their civilization is collectively gazing at the stars once the sun has set.

Social Structure:
The Banforo are very social towards each other and share strong bonds. Ressources are always shared and private ownership doesn't exist for goods with material value. The form of government can be called communistic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources

@MatGB
Copy link
Member

MatGB commented Sep 11, 2015

I love this idea, glad you've had time for it, and you've put way more work in than I would've, I'd have just had them have crashed cryonic colony pods and create a ship in the same way as the Dragon Tooth.

I wasn't sure about the use of "good chance" in the ruins description but if I'm reading the script right it actually is an accurate description and although I don't like the language I can't think of anything better.

Fix the typos I'll merge it, I need to recompile at some point soon anyway and these guys look fun.

@Dilvish-fo
Copy link
Member

Rather than add a new version of ANCIENT_RUINS_DEPLETED_X for every species, it seems to me it would be a much better structure to leave the ANCIENT_RUINS_DEPLETED as it was, and simply add a new special for the possibility of resurrecting the given species. That seems like a much cleaner (and more flexible) way to maintain things, both from the pure scripting perspective, and from the AI adjustment perspective.

As it stands this would break the AI's understanding of ANCIENT_RUINS_DEPLETED, for no good reason it seems to me. The adjustment for that limited aspect of it wouldn't be hard, but it just doesn't seem like a good structure to me.

@Deepsloth
Copy link
Contributor Author

That's a good idea Dilvish. That would indeed be a lot cleaner and flexible.
I will create an update when i find some time.

@Vezzra Vezzra added the category:refactoring The Issue/PR describes or contains an improved implementation. label Sep 13, 2015
@Vezzra Vezzra added this to the Next release milestone Sep 13, 2015
- The Remains of extinct species will now be separate specials in addition to the Ancient Ruins depleted special.
- Added additional SitReps for finding extinct species.
@Deepsloth
Copy link
Contributor Author

Update has been added. In addition to the change suggested by Dilvish, i've also added SitReps (including Rumors) for finding extinct species and updated the Kilandow icon.

@wheals
Copy link
Contributor

wheals commented Sep 18, 2015

Looks like the special icons should be in icons/specials_large, rather than huge, since they're not as big as the rest in that folder.

@Deepsloth
Copy link
Contributor Author

Since the icons are downsampled by the engine the specials icon folders other than huge are obsolete. They should probably be removed at one point in the future (and the specials_huge folder can be renamed to just specials).
I don't think it's a good idea to put new icons in obsolete folders.

@MatGB
Copy link
Member

MatGB commented Oct 14, 2015

@Dilvish-fo , just checking you're OK with this going in, I'm going through old PRs and this one looks good to me, testing it a bit at the moment.

@MatGB MatGB self-assigned this Oct 14, 2015
@Dilvish-fo
Copy link
Member

I haven't tested it, but have no objection to it now that it's been restructured (and I agree the idea is nice).

@MatGB
Copy link
Member

MatGB commented Oct 14, 2015

Cool, I'm playing now and got Misiorla first off, given I had 4 Mu Ursh homeworlds that wasn't as big a boost, it looks fine, I want to do a few tweaks, give the sitreps a priority, then I'll commit the lot. I don't have a strong opinion on the balance of the species yet but that can come later, species overall need a proper balance pass once the priority system is bedded in (which I'll get back to soon).

effects = SetTargetResearch value = Value + Target.Population * 5 * [[RESEARCH_PER_POP]]
]
graphic = "icons/specials_huge/ancient_ruins_excavated.png"
'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something, but after going over all the changes of this PR I can't find where this macro is being used... so what's the purpose of this new macro? Or is that a leftover of the first draft, where you had several versions of the ANCIENT_RUINS_DEPLETED_SPECIAL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'm finishing off a few polishes to it to commit at the same time (minor tweaks in wording, sitrep priorities), it does appear to not being used, I'll confirm that and delete it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, got distracted, committed then saw this, I'll fix tomorrow.

@Vezzra
Copy link
Member

Vezzra commented Oct 15, 2015

Looks good as far as I can see 😃

@MatGB
Copy link
Member

MatGB commented Oct 15, 2015

Closed with 3e239a1

@MatGB MatGB closed this Oct 15, 2015
@Deepsloth Deepsloth deleted the xenoresurrection branch July 26, 2016 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:refactoring The Issue/PR describes or contains an improved implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants