spatial flux rework

[agrrr3]

discussion:
https://freeorion.org/forum/viewtopic.php?p=104863

missing:
graphics for the composite are missing (and the lance could be better), those are already requested on the forums

https://freeorion.org/forum/viewtopic.php?f=10&t=12175&p=108300
https://freeorion.org/forum/viewtopic.php?f=10&t=12176

[agrrr3]

I am not able to interpret the CI failures... TestPythonParser (Failed) - as far as I can see this PR should not be able to break anything there

[geoffthemedio]

TestPythonParser (Failed) - as far as I can see this PR should not be able to break anything there

I'm not sure, as @o01eg set up those tests, but it looks like the Python parser tests also run the existing C++ / Boost tests on the .focs.txt files, and checks the resulting number of techs. Since you're adding more techs, the numbers don't match what it expects.

[agrrr3]

tests on the .focs.txt files, and checks the resulting number of techs. Since you're adding more techs, the numbers don't match what it expects.

thanks, missed that part of the test. guess the test is brittle though

[geoffthemedio]

I think the purpose is to let him check that the Python and Boost parsers produce the same results, and that specific test is perhaps just there as a sanity check or warning that something was changed so that whatever Python scripts are being parsed might need updating?

[agrrr3]

reworked the stealth effect and fixed the lance damage (forgot it does only half the damage as it is a close range weapon)

[agrrr3]

playtested this, good to go (after review)

[agrrr3]

@o01eg @geoffthemedio can we merge, please

[geoffthemedio]

I don't have time to look at this until later this week

[agrrr3]

addressed the review comments and did some further fixes on the descriptions; the hull descriptions were not up to date with the values.

[agrrr3]

Oh, and should I commit the gimp file i used to compose the flux-lance.png to the asset repository (maybe at art/icons/ship_parts/
?). Artistic depth is not high, i fiddled with the texture and colors in death_spore.blend and composed it on top of the death_spore.png (and added a color change layer)
As far as I can see the compositions of renders are not committed there currently.

[geoffthemedio]

If it's just overlaying existing available textures and tweaking colours, it's probably not super useful to archive the intermediate file format, but I'm not sure about that sort of thing.

[Vezzra]

@agrrr3,

Oh, and should I commit the gimp file i used to compose the flux-lance.png to the asset repository (maybe at art/icons/ship_parts/

Yes, please.

As far as I can see the compositions of renders are not committed there currently.

There are a lot of images which don't have corresponding source files in the assets repo, because the assets repo was introduced only in 2014 (over a decade after the project started), and by that time we only had been able to recover the source files of a couple of the artwork in FO. Most of them we don't have.

Even after that we often/sometimes forgot to ask for the source files of artwork various people contributed, so unfortunately the assets repo is quite incomplete.

But that does not mean we still try to get every source file in we can... 😉