specials, likes & dislikes of fields & species #3701
Conversation
geoffthemedio
added
category:feature
|
the python check complains of HAEMAESTHETIC_DETECTION_DESC in fr.txt - but i renamed/removed that and is nowhere to be found, maybe something wrong with the st-tool.py's |
|
try rebasing on master? a pull request shouldn't have any merge commits in it. |
will do. this was probably because i merged the suggested changes which were committed on github back into my local branch. |
Try not to do that. Rebase your branch on master instead. |
st-pa-fo
force-pushed
the
stpa-specials+fields
branch
2 times, most recently
from
79b9c46
to
579c23f
Compare
st-pa-fo
changed the title
|
rebased on master.
|
st-pa-fo
force-pushed
the
stpa-specials+fields
branch
from
ce9fb67
to
d49fc9f
Compare
|
re-rebased on master. incorporated feedback. |
|
yep the string test fails no more, but all the other stuff .. seems like that came from rebasement on master maybe? edit; nope: test failed because of a new tech which changes the number of total techs expected by the test. increasing expected techs by two. |
|
added another core slot ship part. nothing special. see screenshot attached.
|
| @@ -15556,6 +15556,12 @@ ST_CLOAK_4_DESC | |||
|
|
|||
| Improves [[metertype METER_STEALTH]] of ship on which it is mounted by modulating the frequency of any matter waves emitted from the ship to match that of the background radiation. [[NO_STACK_STEALTH_SHIP_PARTS]]''' | |||
|
|
|||
| AR_REINFORCED_HULL | |||
| Self-Reinforcing Hull | |||
There was a problem hiding this comment.
Needs a better name. Maybe Auto-Repair Bay or Hull Regenerator
There was a problem hiding this comment.
can you propose one acceptable name?
i can perform refactorings when ever necessary and as often as desired. or i could make two module variations for both those proposed names, one stays core slot the other as internal slot?
There was a problem hiding this comment.
can you propose one acceptable name?
I did in the comment you replied to...
There was a problem hiding this comment.
Should be "Hull Regenerator" rather than "Self-Reinforcing Hull", as it's not actually a hull.
| @@ -0,0 +1,27 @@ | |||
| Part | |||
| name = "AR_REINFORCED_HULL" | |||
There was a problem hiding this comment.
This is similar to the regeneration of living hulls, without the out-of-combat restriction...
There was a problem hiding this comment.
also similar to basic damage control and fleet field repair, except it is different in that it is coupled to a ship module that needs to be mounted in the core slot.
There was a problem hiding this comment.
How many different ways to repair ships are needed? What's notable (not just different) about this one?
There was a problem hiding this comment.
it gives more design options for capital ships with available core slots, since there are only very few preexisting core clot ship parts to fill them with.
as to the first questen – a counter question 'how many different kinds of ship beam weapons are necessary' comes to mind, or how many different kinds of planetary environment, or how many native species .. i will not speak those out loud though and keep them to myself.. – and a counter question would not really be an answer anyway, so honestly, i do not know a good answer to that.
|
please stop adding more and more unrelated stuff to the same pull request... |
aye. these parts and techs came out of the discussion of thread "species effect for like/dislike of fieldtypes" (https://www.freeorion.org/forum/viewtopic.php?f=6&t=12261&start=15). there is still work in progress, the krill siren which was screenshotted in that thread too. so only the krill siren to be added, then that'll be all. |
…asgiants than before
…etup-monster settings
…es of other species - fixing apparent bug in SP_LEMBALALAM which did not reference basic population macro - internal rearranging of likes/dislikes in some more species by applying "sort | uniq"
…/wmich.edu/mus-gened/mus150/Glossary.pdf (which has no copyright notice on it and anyway, words in a glossary can not be copyrighted afaistr)
… frequency galaxy setup option is the lowest two possible settings - adding species likes and dislikes effects to apply moderate happiness bonus/malus for colonies being inside or close to liked or disliked fields - prettier accounting labels for likes and dislikes using <i>italics</i>
- the rotten core module mounts in a core slot and attracts bad fields and repels good fields on the galactic map
…back, changing tech prequesits and increasing research cost
…ause they are plants and dislike being shadowed
st-pa-fo
force-pushed
the
stpa-specials+fields
branch
from
af48734
to
4c93811
Compare
|
rebased on master |
Is this meant to be done? Still has some commented out bits, is marked draft, and has some error-fix commits in the middle that should be merged into the commit that introduced the problem... |
|
@st-pa-fo poke? |
– slight adjustment to specials placement: allow a few more appropriate specials on gas giants and on asteroids, see also https://www.freeorion.org/forum/viewtopic.php?f=6&t=12262
– introducing effect for species likes and dislikes of other species, see also https://www.freeorion.org/forum/viewtopic.php?f=6&t=12206
– fixing minor bug in SP_LEMBALALAM, see also https://www.freeorion.org/forum/viewtopic.php?p=109937#p109937
– and some more small stuff coming up: effects for (dis)liking field types, some new buildings and ship parts to attract/repel fields/monsters, see also https://www.freeorion.org/forum/viewtopic.php?f=6&t=12261