more gradual and less effective BLD_LIGHTHOUSE effect for planets/buildings

[agrrr3]

was -30, now between -20 to -30 for ships and -0 to -10 for all other objects

[geoffthemedio]

Is there a discussion thread or does this need testing? I don't have an opinion on the balance aspects.

[MichaelCourtney]

Is there a discussion thread or does this need testing? I don't have an opinion on the balance aspects.

https://www.freeorion.org/forum/viewtopic.php?f=15&t=12509

[agrrr3]

note, this is intended for 0.5 in order to make it a viable strategy to use stealth as a defense for planets

[geoffthemedio]

this causes parse errors:

Error: 0:06.866641 {0x00007ff37a7fe6c0} [error] server : ReportParseError.cpp:92 : /freeorion/build/default/scripting/buildings/LIGHTHOUSE.focs.txt:132:12: Parse error.  Expected (?-i:effects) here:
3: 
3:         // takes the maximum age of all lighthouse buildings in the system regardless of owner (by just triggering for the oldest ones)
3:         EffectsGroup
3:             scope = WithinDistance distance = 0.00001 condition = Source
3:             stackinggroup = "LIGHTHOUSE_CATALOG_STEALTH_STACK"
3:             activation = (Source.Age >= (Statistic Max value = LocalCandidate.Age condition = And [
3:             ^
3:                 InSystem id = Source.SystemID
3:                 Building name = "BLD_LIGHTHOUSE"
3:             ]))
3:             accountinglabel = "BLD_LIGHTHOUSE_CATALOG_STEALTH_LABEL"
3:             effects = SetStealth value = Value - min(Source.Age, NamedReal name = "BLD_LIGHTHOUSE_CATALOG_STEALTH_MALUS" value = 10)

[agrrr3]

Is anything stopping the merge?

[Vezzra]

Is anything stopping the merge?

No objections so far, but also no one has done the merge yet. I'm going to create the release branch on Sunday (Nov 13th), unless there are objections againt it, this PR should be merged until then.

If there are no objections, but the branch still not merged when I create the release branch, I'm going to do the merge myself before (unless I forget, which is always a possibility considering my age... 😉).