Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add More Named values for pedia #4255

Merged
merged 1 commit into from Oct 22, 2022
Merged

Add More Named values for pedia #4255

merged 1 commit into from Oct 22, 2022

Conversation

MichaelCourtney
Copy link
Contributor

Update to

#3958

There is still more of them to do

@MichaelCourtney MichaelCourtney force-pushed the namedvaluespedia branch 5 times, most recently from dfe2a07 to 48caa2c Compare October 20, 2022 18:37
@MichaelCourtney
Copy link
Contributor Author

hmm, don't really understand the linters and tests.

@geoffthemedio geoffthemedio added component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. component:art music text assets The Issue/PR deals with creating, modifying or verifying game assets. category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:user manual The Issue/PR deals with end-user documentation targeted towards players and server hosters. labels Oct 22, 2022
@geoffthemedio
Copy link
Member

@Cjkjvfnby @o01eg any help with the linter failure?

@o01eg
Copy link
Contributor

o01eg commented Oct 22, 2022

@geoffthemedio I think it was fixed in #4258

@MichaelCourtney
Copy link
Contributor Author

@geoffthemedio I think it was fixed in #4258

Seems so. Rebased on latest master and they all pass

@geoffthemedio geoffthemedio merged commit 064f9ea into freeorion:master Oct 22, 2022
@geoffthemedio geoffthemedio added the status:merged All relevant commits of this PR were merged into the master development branch. label Oct 22, 2022
@Vezzra Vezzra added this to the v0.5 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:art music text assets The Issue/PR deals with creating, modifying or verifying game assets. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. component:user manual The Issue/PR deals with end-user documentation targeted towards players and server hosters. status:merged All relevant commits of this PR were merged into the master development branch.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MichaelCourtney @geoffthemedio @o01eg @Vezzra