Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing scaling #4387

Merged
merged 1 commit into from Feb 12, 2023
Merged

Fix missing scaling #4387

merged 1 commit into from Feb 12, 2023

Conversation

MichaelCourtney
Copy link
Contributor

No description provided.

@MichaelCourtney MichaelCourtney mentioned this pull request Feb 3, 2023
Closed
@Vezzra Vezzra added category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. labels Feb 6, 2023
@Vezzra
Copy link
Member

Vezzra commented Feb 6, 2023

Should this also go into 0.5?

@MichaelCourtney
Copy link
Contributor Author

I'd count fortress mines doing the wrong damage as a bug, so probably for 0.5.

With it's partner over here:

#4388

All the mines should show correct damage in the pedia even with non-default scaling settings

@Vezzra Vezzra added the status:cherry-pick for release The PR should be applied to the currently open release branch. label Feb 7, 2023
@Vezzra Vezzra added this to the v0.5 milestone Feb 7, 2023
@agrrr3
Copy link
Contributor

agrrr3 commented Feb 10, 2023

code looks good to me

@geoffthemedio geoffthemedio merged commit b1cf4d9 into freeorion:master Feb 12, 2023
@geoffthemedio geoffthemedio added the status:merged All relevant commits of this PR were merged into the master development branch. label Feb 12, 2023
Vezzra pushed a commit that referenced this pull request Feb 13, 2023
@MichaelCourtney @Vezzra
Fix missing scaling (#4387)
cd41bb2 
(cherry picked from commit b1cf4d9)
@Vezzra Vezzra removed the status:cherry-pick for release The PR should be applied to the currently open release branch. label Feb 13, 2023
@MichaelCourtney MichaelCourtney deleted the missingscaling branch May 31, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. status:merged All relevant commits of this PR were merged into the master development branch.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MichaelCourtney @Vezzra @agrrr3 @geoffthemedio