Always set Max?-Capacity-SecondaryStat for WEAPON_BASE_EFFECTS

[agrrr3]

fixes #4555 and #4517 in master

[agrrr3]

Ok, seems i finally won against the linters. Ready to merge from my side.

playtested:

• defensive and offensive flanking work out of supply
• md2 upgrade happens only in supply
• flux lance, arc disruptor, flak, md1/md2 have the expected values in the ship designer

[geoffthemedio]

Does using flanking allow a ship to upgrade permanently outside of supply? ie. have 72/72, get upgrade tech so have 72/100, use flanking for a turn to have 100/100, keep 100/100 despite never having been in supply range to get upgrade?

[agrrr3]

Does using flanking allow a ship to upgrade permanently outside of supply? ie. have 72/72, get upgrade tech so have 72/100, use flanking for a turn to have 100/100, keep 100/100 despite never having been in supply range to get upgrade?

in theory not. there is no state involved - the meters get set to maximum every turn. and the max meters get set to values; not modified.

the weapon upgrade techs fire if last turn resupplied is >= the turn the tech got researched.

i will playtest though.

[agrrr3]

playtested OK:

• two stationary ships out of supply increase their stats with flanking
• research Laser-2 does not increase
• unapplying flanking policy makes damages drop to previous values
• flying into supply upgrades laser damage
• applying flanking increases damage on top of tech damage

[geoffthemedio]

the weapon upgrade techs fire if last turn resupplied is >= the turn the tech got researched.

Right, that now works differently from how I remembered.

[o01eg]

the weapon upgrade techs fire if last turn resupplied is >= the turn the tech got researched.

Can we change it that way it doesn't use turn the tech was researched? Then the other empires' tech info could be disabled.

[geoffthemedio]

I suppose you could add an empire meter or meters to track various weapon upgrade levels, and key the effect off that. Or add a series of specials to the capital and test for / add effects to that. Not sure how you want it to work though... I assume other empires should be able to predict the weapon levels o an empire, but not know that or when that empire researched a tech? Need to share the info somehow then, but specials on the capital or empire meters probably aren't improvements over sharing tech info, in that case...

[agrrr3]

the weapon upgrade techs fire if last turn resupplied is >= the turn the tech got researched.

Can we change it that way it doesn't use turn the tech was researched? Then the other empires' tech info could be disabled.

Is wrong effects accounting a big problem here? For implementation the base is that the other empire needs to observe a source of the effect in order for correct accounting. So specials/meters on the capital planet won't really work. Also I do not know if there are public empire meters.

Hiding the research turns but publishing the researched tech (either per FOCS or via public empire meters) would work partly; the effect accounting for ships which are not upgraded would show an unknown malus, but the upgraded ones would have correct accounting.

Another option would be to add a special per ship set to the current damage value coming from the tech (so lower if not upgraded yet) - the special can be observed by enemies so accounting would work. One could probably also repurpose e.g. the max meter for this - we do not really need a max meter for damage anymore. Some complexity/choices there how to handle gifting though; should the base damage downgrade to highest lower tech?

Anyway I think all of this should not delay merging the PR.