Other Tweaks #4765
Merged
Other Tweaks #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffthemedio
added
component:internal
geoffthemedio
force-pushed
the
scratch3
branch
7 times, most recently
from
149b1ee
to
4f3f48e
Compare
geoffthemedio
force-pushed
the
scratch3
branch
16 times, most recently
from
2df39a2
to
7e33ce1
Compare
geoffthemedio
force-pushed
the
scratch3
branch
2 times, most recently
from
681f406
to
128380e
Compare
geoffthemedio
force-pushed
the
scratch3
branch
3 times, most recently
from
9e8d5a7
to
720f4e3
Compare
-treat fields as always visible on map when there is no client empire -don't attempt to look up ALL_EMPIRES as an empire ID
… ID is ALL_EMPIRES
…Strengths since it also provides monster info -const -grooming
…kades function -move extracting blockading ships for empires into a separate GetBlockadingFleetsForEmpires function -rename ServerApp::m_empire_vis_overrides to m_empire_fleet_combat_initiation_vis_overrides -noexcept -adjust logging formatting and add more debug logging for combat condition determination
-rename [Set/Apply]EmpireObjectVisibilityOverrides to [Set/Apply]ObjectVisibilityOverrides -rename GetEmpiresPositionDetectionRanges to GetEmpiresAndNeutralPositionDetectionRanges -pass ScriptingContext instead of just EmpireManager to ApplyEffectDerivedVisibilities and UpdateEmpireObjectVisibilities, -pass raw pointers instead of shared_ptr -const / grooming -rename m_empire_object_visibility_overrides to m_fleet_blockade_ship_visibility_overrides -rework CheckObjects with auto instead of explicit template parameter -remove unneded empire_id parameter to GetEmpiresDetectionStrengths and GetEmpiresPositionsPotentiallyDetectableObjects -set neutral travelled starlane endpoints as visible to neutrals (as for empires)
…stem -log empires with any fleets present, along with those with armed aggressive/obstructive
…mbatInfo -simplify combat visibility initialization code
-log stacktrace if a current value variant has the wrong type
geoffthemedio
added
the
status:merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...