additional ListBox iterator safety checks #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer to err on the side of extra safety checks for this sort of stuff... |
Vezzra
added
the
category:bug
|
Not entirely sure if that's an enhancement or a bugfix, but I guess more of the latter, so I tagged it accordingly. Feel free to correct that if you want. |
|
Bugfix is probably the best fit. |
Dilvish-fo
added a commit
that referenced
this pull request
May 21, 2015
…ety_checks additional ListBox iterator safety checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the three changes here, I think that the middle one is probably unnecessary (given it is a Deselect operation), but shouldn't hurt, and the other two seem definitely prudent to me.