Remove support for Ruby v1.8 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended maintenance of Ruby v1.8.7 ended on 31 Jul 2014 [1] and Mocha support for Ruby v1.8 has been deprecated since v1.10 [2]. Recent work in #534 has run into problems with files containing keyword arguments not being parsable by Ruby v1.8 and so I think the time has come to drop support. Note that I had to change a couple of hard-coded line numbers in unit tests to match up with the changed source code in lib/mocha/stubbed_method.rb. [1]: https://www.ruby-lang.org/en/news/2014/07/01/eol-for-1-8-7-and-1-9-2/ [2]: c5f8496
floehopper
force-pushed
the
remove-support-for-ruby-v1.8
branch
from
81437e9
to
90d6d6a
Compare
This was referenced Aug 21, 2022
8 tasks
floehopper
pushed a commit
that referenced
this pull request
Aug 31, 2022
Reflection-related methods returning arrays of method names, e.g. Object#public_methods, Module#public_instance_methods, etc, seem to have changed from returning arrays of strings in Ruby v1.8 to returning arrays of symbols in Ruby v1.9. See also 9705028. Since we dropped support for Ruby v1.8 in #536, we can safely remove the call to to_sym from Assertions#assert_method_visibility.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended maintenance of Ruby v1.8.7 ended on 31 Jul 2014 and Mocha
support for Ruby v1.8 has been deprecated since v1.10.
Recent work in #534 has run into problems with files containing keyword
arguments not being parsable by Ruby v1.8 and so I think the time has
come to drop support.